[Swan] Phasing out #ifdef DEBUG ?

[David McCullough]

Paul Wouters wrote the following:
> On Sat, 16 Mar 2013, D. Hugh Redelmeier wrote:
> 
> >Clearly nobody builds without DEBUG because the build doesn't work.
> >Not that it cannot be fixed, only that it is a proof that nobody
> >cares.
> >
> >I kind of like the discipline of DEBUG but don't think that the memory
> >saving is worthwhile given the maintenance/testing costs.
> >
> >Do any embedded folk care?  Are they likely to speak up?
> 
> Some did, but they were talking about the addition of libnss :)

Boo hiss nss ;-) ;-)

> Once we have an option to choose between openssl and nss, I think
> they'll be happy enough to not care about the DEBUG stuff.

IMO,  you cannot deploy openswan without debug,  that is one of openswans
greatest strengths for in the field issues.  Thats said,  a very
specialised embedded solution may have no need for it.

As log as all debug is done through a defined API,  taking it out is never
going to be a big issue when and if it's needed.

If I were to turn off debug it would be the in-kernel debug,  and only to
save space, increased speed.  It affects performance very little these days
but it is something I regularly check on.

Cheers,
Davidm

-- 
David McCullough,  davidm at spottygum.com,   Ph: 0410 560 763