[Swan-dev] Ipcomp and get_sa_info()

[Paul Wouters]

Are we sure the code was not wrong ?

Some tests with ipcomp used ping which didn’t compress enough and would actually go out over the non-ipcomp transform.

I believe our code was wrong but I also think we might need to pull traffic from the regular and ipcomp state.

Paul

Begin forwarded message:

> From: "D. Hugh Redelmeier" <hugh at vault.libreswan.fi>
> Date: March 25, 2022 at 21:30:54 GMT+1
> To: swan-commit at lists.libreswan.org
> Subject: [Swan-commit] Changes to ref refs/heads/main
> Reply-To: swan-dev at lists.libreswan.org
> 
> New commits:
> commit 1062a663482b9b3841f0a48e5c99b4dd70757793
> Author: D. Hugh Redelmeier <hugh at mimosa.com>
> Date:   Fri Mar 25 16:15:15 2022 -0400
> 
>    pluto: tidy things around ipsec_proto_info.present and get_sa_info()
> 
>    - get_sa_info does nothing for IPCOMP so don't call it for such SAs
> 
>    - get rid of a few confusing redundant parentheses
> 
>    - remove redundant test terms from get_sa_info
> 
>    - show_established_child_details: display flow counts for each kind of
>      SA in the same order.
> 
>    - show_established_child_details: don't try to display flow counts for
>      IPCOMP from get_sa_info since it never gives any
> 
> _______________________________________________
> Swan-commit mailing list
> Swan-commit at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-commit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libreswan.org/pipermail/swan-dev/attachments/20220325/be1f759e/attachment.htm>