<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Are we sure the code was not wrong ?<div><br></div><div>Some tests with ipcomp used ping which didn’t compress enough and would actually go out over the non-ipcomp transform.</div><div><br></div><div>I believe our code was wrong but I also think we might need to pull traffic from the regular and ipcomp state.</div><div><br></div><div>Paul<br><br><div dir="ltr">Begin forwarded message:</div><div dir="ltr"><br></div><blockquote type="cite"><div dir="ltr"><b>From:</b> "D. Hugh Redelmeier" <hugh@vault.libreswan.fi><br><b>Date:</b> March 25, 2022 at 21:30:54 GMT+1<br><b>To:</b> swan-commit@lists.libreswan.org<br><b>Subject:</b> <b>[Swan-commit] Changes to ref refs/heads/main</b><br><b>Reply-To:</b> swan-dev@lists.libreswan.org<br><br></div></blockquote><blockquote type="cite"><div dir="ltr"><span>New commits:</span><br><span>commit 1062a663482b9b3841f0a48e5c99b4dd70757793</span><br><span>Author: D. Hugh Redelmeier <hugh@mimosa.com></span><br><span>Date: Fri Mar 25 16:15:15 2022 -0400</span><br><span></span><br><span> pluto: tidy things around ipsec_proto_info.present and get_sa_info()</span><br><span></span><br><span> - get_sa_info does nothing for IPCOMP so don't call it for such SAs</span><br><span></span><br><span> - get rid of a few confusing redundant parentheses</span><br><span></span><br><span> - remove redundant test terms from get_sa_info</span><br><span></span><br><span> - show_established_child_details: display flow counts for each kind of</span><br><span> SA in the same order.</span><br><span></span><br><span> - show_established_child_details: don't try to display flow counts for</span><br><span> IPCOMP from get_sa_info since it never gives any</span><br><span></span><br><span>_______________________________________________</span><br><span>Swan-commit mailing list</span><br><span>Swan-commit@lists.libreswan.org</span><br><span>https://lists.libreswan.org/mailman/listinfo/swan-commit</span><br></div></blockquote></div></body></html>