[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

2 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1514722:  Error handling issues  (CHECKED_RETURN)
/programs/pluto/pluto_shutdown.c: 186 in exit_epilogue()


________________________________________________________________________________________________________
*** CID 1514722:  Error handling issues  (CHECKED_RETURN)
/programs/pluto/pluto_shutdown.c: 186 in exit_epilogue()
180     	free_virtual_ip();	/* virtual_private= */
181     	free_pluto_main();	/* our static chars */
182     	free_impair_message(logger);
183     
184     	/* report memory leaks now, after all free_* calls */
185     	if (leak_detective) {
>>>     CID 1514722:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "report_leaks" without checking return value (as is done elsewhere 8 out of 10 times).
186     		report_leaks(logger);
187     	}
188     	close_log();	/* close the logfiles */
189     #ifdef USE_SYSTEMD_WATCHDOG
190     	pluto_sd(PLUTO_SD_EXIT, pluto_exit_code);
191     #endif

** CID 1514721:  Error handling issues  (CHECKED_RETURN)
/programs/algparse/algparse.c: 703 in main()


________________________________________________________________________________________________________
*** CID 1514721:  Error handling issues  (CHECKED_RETURN)
/programs/algparse/algparse.c: 703 in main()
697     		test(logger);
698     		if (failures > 0) {
699     			fprintf(stderr, "%d FAILURES\n", failures);
700     		}
701     	}
702     
>>>     CID 1514721:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "report_leaks" without checking return value (as is done elsewhere 8 out of 10 times).
703     	report_leaks(logger);
704     
705     	lsw_nss_shutdown();
706     
707     	exit(failures > 0 ? PLUTO_EXIT_FAIL : PLUTO_EXIT_OK);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYh0oy_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ38OmA9Wit0pTao3FP2yZXip-2F877lcVP-2BvWO7-2FBZ4Vlme8VZzCGdVhip-2BZu-2BonUQ6zsiqOOEnPGGwV0tI5TRGl4HE76i7v-2BGy2jweGa7GyaGiW3-2Bq6sb4okwP-2BvPIZeltKewlheWCioKyeECzm-2FRxIkN9Sr3GzIHwHK3tkwBL6WKitBxUPVnH5g8qElLZFOvl9U-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxifWOk_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ38OmA9Wit0pTao3FP2yZXip-2F877lcVP-2BvWO7-2FBZ4Vlme-2Fb7aq25QBpA39PfiKcK5EvzA9alYDqXgnT8UBHchP5Gh-2Bgu63qRb-2FFQe-2B-2Be0zX62Sks8hDNz05u216jRiZ7l-2BdPxVPUeniCIRdM5VL6B53i6LxCTyey3OyE4H7TZOkZqeL6T1ctTxd9sdh2l-2FXN8Gk-3D