[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1511340:  Performance inefficiencies  (PASS_BY_VALUE)
/programs/pluto/ikev2_ts.c: 1119 in scribble_request_ts_on_connection()


________________________________________________________________________________________________________
*** CID 1511340:  Performance inefficiencies  (PASS_BY_VALUE)
/programs/pluto/ikev2_ts.c: 1119 in scribble_request_ts_on_connection()
1113     
1114     	return false;
1115     }
1116     
1117     static void scribble_request_ts_on_connection(struct child_sa *child,
1118     					      struct connection *c,
>>>     CID 1511340:  Performance inefficiencies  (PASS_BY_VALUE)
>>>     Passing parameter n of type "struct narrowed_traffic_selectors" (size 136 bytes) by value.
1119     					      struct narrowed_traffic_selectors n,
1120     					      indent_t indent)
1121     {
1122     	if (c != child->sa.st_connection) {
1123     		connection_buf from, to;
1124     		dbg_ts("switching #%lu from "PRI_CONNECTION" to just-instantiated "PRI_CONNECTION,


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYxntL_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ39kUV3yBfoFBkfgVxZo0nWLnw-2FyFTktK-2FDxlgP7VdIyoEaSjo-2FO4sxvwULJYLzeZuEC8y6uWM4dULVIUFuV1UOgDaQY-2FhkOBQnq7DfJIwO4eNSdTn4sdUZOtm2pi-2BYWj7MpPVi2KtXIV3zGQHdfulZHGbqtDzqehhAWsQPpAcUrO4awNC92f6S0yrE9gVF2MZU-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxixryq_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ39kUV3yBfoFBkfgVxZo0nWLnw-2FyFTktK-2FDxlgP7VdIyoC8TwJgZGPBAo4xxHYFJilKcQH3JV4qfSYwqF2g3t1mPWTEjnrmLgVGS5tuS03IaZEXJ0yXm56XiY6XDk0grpEX-2BLM-2BtCG1Gjibw7mPD3dMPME556ZqBuZBEDuCd8oLxgzKsyDFJ1-2BC8bPN-2BOTSPpyI-3D