Hi,
Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.
2 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1506859: Null pointer dereferences (REVERSE_INULL)
/programs/pluto/ikev2_create_child_sa.c: 1345 in process_v2_CREATE_CHILD_SA_rekey_ike_request_continue_1()
________________________________________________________________________________________________________
*** CID 1506859: Null pointer dereferences (REVERSE_INULL)
/programs/pluto/ikev2_create_child_sa.c: 1345 in process_v2_CREATE_CHILD_SA_rekey_ike_request_continue_1()
1339 pexpect(larval_ike->sa.st_sa_role == SA_RESPONDER);
1340 pexpect(larval_ike->sa.st_state->kind == STATE_V2_REKEY_IKE_R0);
1341 dbg("%s() for #%lu %s",
1342 __func__, larval_ike->sa.st_serialno, larval_ike->sa.st_state->name);
1343
1344 /* and a parent? */
>>> CID 1506859: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "ike" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1345 if (ike == NULL) {
1346 pexpect_fail(larval_ike->sa.st_logger, HERE,
1347 "sponsoring child state #%lu has no parent state #%lu",
1348 larval_ike->sa.st_serialno, larval_ike->sa.st_clonedfrom);
1349 /* XXX: release what? */
1350 return STF_INTERNAL_ERROR;
** CID 1506858: Null pointer dereferences (REVERSE_INULL)
/programs/pluto/ikev2_create_child_sa.c: 1385 in process_v2_CREATE_CHILD_SA_rekey_ike_request_continue_2()
________________________________________________________________________________________________________
*** CID 1506858: Null pointer dereferences (REVERSE_INULL)
/programs/pluto/ikev2_create_child_sa.c: 1385 in process_v2_CREATE_CHILD_SA_rekey_ike_request_continue_2()
1379 passert(larval_ike->sa.st_sa_role == SA_RESPONDER);
1380 pexpect(larval_ike->sa.st_state->kind == STATE_V2_REKEY_IKE_R0);
1381 dbg("%s() for #%lu %s",
1382 __func__, larval_ike->sa.st_serialno, larval_ike->sa.st_state->name);
1383
1384 /* didn't loose parent? */
>>> CID 1506858: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "ike" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1385 if (ike == NULL) {
1386 pexpect_fail(larval_ike->sa.st_logger, HERE,
1387 "sponsoring child state #%lu has no parent state #%lu",
1388 larval_ike->sa.st_serialno, larval_ike->sa.st_clonedfrom);
1389 /* XXX: release child? */
1390 return STF_INTERNAL_ERROR;
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYVAUa_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ39bXKzwFM1Xz4LHpxIeCg8U7oNMJPEu6lUIIYLzjNQWAQ1xcYzoWN64cTBMbn9L49H05F5QZZTDYEVui2ouzhVW5qzHJe-2Bw6srmSiam9fGVoPiSkv7e2fsMCjEhnfijAhFpzCtMQP70fArjGn7dHNWCvsw1HQSSkmteWHEpSrHEfyD6MTtYv0-2FRaevJKUAwjIM-3D
To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxiFEwu_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ39bXKzwFM1Xz4LHpxIeCg8U7oNMJPEu6lUIIYLzjNQWAfE-2FUnddW16tHJtk9uC1zr1qcD5Hm4mJSVeFNUUiIhyb5rtDvb2Lmf0vjYnI9MGsmd607irH7wRduPkzgO2uny1yQMWWsmpqFwxWZTsIqskEtUOc4jHjnMDAIk161XuYFcjM5OJDB0guSZVtoaXgSqI-3D