[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

2 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1506839:  Null pointer dereferences  (REVERSE_INULL)
/programs/pluto/ikev2_create_child_sa.c: 878 in process_v2_CREATE_CHILD_SA_request_continue_1()


________________________________________________________________________________________________________
*** CID 1506839:  Null pointer dereferences  (REVERSE_INULL)
/programs/pluto/ikev2_create_child_sa.c: 878 in process_v2_CREATE_CHILD_SA_request_continue_1()
872     	 * does a second continue. Yuck!
873     	 */
874     	pexpect(larval_child->sa.st_state->kind == STATE_V2_NEW_CHILD_R0 ||
875     		larval_child->sa.st_state->kind == STATE_V2_REKEY_CHILD_R0);
876     
877     	/* and a parent? */
>>>     CID 1506839:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "ike" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
878     	if (ike == NULL) {
879     		pexpect_fail(larval_child->sa.st_logger, HERE,
880     			     "sponsoring child state #%lu has no parent state #%lu",
881     			     larval_child->sa.st_serialno, larval_child->sa.st_clonedfrom);
882     		/* XXX: release what? */
883     		return STF_INTERNAL_ERROR;

** CID 1506838:  Null pointer dereferences  (REVERSE_INULL)
/programs/pluto/ikev2_create_child_sa.c: 968 in process_v2_CREATE_CHILD_SA_request_continue_2()


________________________________________________________________________________________________________
*** CID 1506838:  Null pointer dereferences  (REVERSE_INULL)
/programs/pluto/ikev2_create_child_sa.c: 968 in process_v2_CREATE_CHILD_SA_request_continue_2()
962     	 * then the per-transition functions can all call common code.
963     	 */
964     	pexpect(larval_child->sa.st_state->kind == STATE_V2_NEW_CHILD_R0 ||
965     		larval_child->sa.st_state->kind == STATE_V2_REKEY_CHILD_R0);
966     
967     	/* didn't loose parent? */
>>>     CID 1506838:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "ike" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
968     	if (ike == NULL) {
969     		pexpect_fail(larval_child->sa.st_logger, HERE,
970     			     "sponsoring child state #%lu has no parent state #%lu",
971     			     larval_child->sa.st_serialno, larval_child->sa.st_clonedfrom);
972     		delete_state(&larval_child->sa);
973     		ike->sa.st_v2_larval_responder_sa = NULL;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYgKrf_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2FTOpbY1zOX6FQKgVlMtW7iiAkna3KQBMj1M-2B-2Fe99fiePx-2BH-2FhA466uJrR-2BafmCgLxWSDuURHL2peeDm-2F58L6i5FJvFL-2F1wtqr8i6ewyxXDTIvc-2FizMEKnlpdMiOQgLXhjLtGyyP0EagDWGyyZ86l0JFFW8SjHFHC1hOgATFadB34rgKDuypNiIjhasydCYTV4-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxicVr-_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2FTOpbY1zOX6FQKgVlMtW7iiAkna3KQBMj1M-2B-2Fe99fieND6xC6fQFYaQ7JaqlvGaGPn9PyeN99IdcZHA4EArbP-2BNBGTu6GzVjKsgCSaUaRsErT5wtUix2uoCwp7m5BQyuTal3Soe5CJKLdga2RrcbeEhrw1X0XqABZJFErA6z0zI2zv6BhQ2OHug5fkXZhx5G8-3D