[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1504706:  Error handling issues  (CHECKED_RETURN)
/programs/pluto/connections.c: 333 in delete_connections_by_name()


________________________________________________________________________________________________________
*** CID 1504706:  Error handling issues  (CHECKED_RETURN)
/programs/pluto/connections.c: 333 in delete_connections_by_name()
327     	bool f = FALSE;
328     
329     	passert(name != NULL);
330     	struct connection *c = conn_by_name(name, strict);
331     
332     	if (c == NULL) {
>>>     CID 1504706:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "foreach_connection_by_alias" without checking return value (as is done elsewhere 6 out of 7 times).
333     		foreach_connection_by_alias(name, delete_connection_wrap, &f, logger);
334     	} else {
335     		for (; c != NULL; c = conn_by_name(name, false/*!strict*/))
336     			delete_connection(c, FALSE);
337     	}
338     }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYkHKS_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2FIZKbinrKdFac-2FuSXfMcUGnSBX1V04EnnRHlvafNXg4BzwjgzqUeUkXMS7IV0aDXpxIvv05muhd2LAMfPRZckmMAZYgfO2rssqexp51uAjJKMS2DtbA0a-2FycHCzz0BIndeybm7uM0yhMZq9wWS4h6r1-2F8XBrGqStjbA7z4rONtv-2BJAoC8IY9EyrN3iwck8JrE-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxi27U9_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2FIZKbinrKdFac-2FuSXfMcUGnSBX1V04EnnRHlvafNXg4J3lfCOTF7lP9nXV3-2BUMKryQA8kuWsKLx-2BotjhFmWwLNV2sKCraU85oItv8USFMR-2Bej9u4NQCtFDaJzPL8C1QDJPy3ap9w3aORRAjTvctedJpviN3HDIXmQuk7rDdA2JaTQxIlRE7-2BpNl80mvH0J4Io-3D