[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1504631:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1504631:  Null pointer dereferences  (FORWARD_NULL)
/programs/pluto/x509.c: 1240 in ikev2_send_cert()
1234     	const struct cert *mycert = c->spd.this.cert.nss_cert != NULL ? &c->spd.this.cert : NULL;
1235     	bool send_authcerts = c->send_ca != CA_SEND_NONE;
1236     	bool send_full_chain = send_authcerts && c->send_ca == CA_SEND_ALL;
1237     
1238     	if (impair.send_pkcs7_thingie) {
1239     		llog(RC_LOG, outpbs->outs_logger, "IMPAIR: sending cert as PKCS7 blob");
>>>     CID 1504631:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "mycert" to "nss_pkcs7_blob", which dereferences it.
1240     		SECItem *pkcs7 = nss_pkcs7_blob(mycert, send_full_chain);
1241     		if (!pexpect(pkcs7 != NULL)) {
1242     			return STF_INTERNAL_ERROR;
1243     		}
1244     		struct ikev2_cert pkcs7_hdr = {
1245     			.isac_critical = build_ikev2_critical(false, outpbs->outs_logger),


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kY6E17_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ39TEKdRBmk5dYFbKZ0CpGgaiiDupcDRM7OnREe3K22j0rneYR9WthG27jpkaGuqKL5oVWUtwy5Sq7ftBCSryj3TgzJxGSAvgVSJmf7zHECHCt7yvKkS-2BT6gRc0elYWe2146UbyHz84H65b2CQC63bzzXqFKaRx73P7H8jt-2F9K3DfTJHXeRAHreUGFZSliifUkk-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxiptWI_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ39TEKdRBmk5dYFbKZ0CpGgaiiDupcDRM7OnREe3K22j0nsGlYVYRtG0rpo-2FP1r5rUJIORMZknS4sHtpIFrVzVPn7azP8sa-2FRX2BnHbbVx3a3853tOEfM-2BcL2hWKAHuX8JDBnWcwy1WEAbuhzNPd8KU2Ph7qy9Wf290W7Zv19Mpp21QTmOdI3zN57s70IEVkz3c-3D