[Swan-dev] use @IPSECBASEVERSION@ when going to 4.x dev cycle.

[Antony Antony]

On Thu, Oct 15, 2020 at 03:03:35PM -0400, Paul Wouters wrote:
> On Thu, 15 Oct 2020, Antony Antony wrote:
> 
> > I am glad to see 4.0 is out.
> > Looking at the commit that bump to 4.0 I notice a drift.
> > 
> > Use of IPSECBASEVERSION as oppesed to @IPSECBASEVERSION@ are popping up
> > 
> > When changing to 4.x cycle would be a good time to drift towards
> > @IPSECBASEVERSION@ again.
> > 
> > Here is a previous discusions and concencus for @IPSECBASEVERSION@
> > https://lists.libreswan.org/pipermail/swan-dev/2018-April/002348.html
> 
> There were thoughts about removing IPSECBASEVERSION alltogether, and
> setting it now to something like "4.1dev".

that sounds a good idea.

I was more focusing on mixed use @. That is confusing.
I think wheather we use 4 or 4.1dev there will be one or more identifiers
which would be replaced by scripts, and those should be in the format 
@IPSECBASEVERSION@ and not the variable style IPSECBASEVERSION.

> While still merging the git short commit hash into that to know the
> exact commit of the dev tree the build was on.

Yes, that is good. Current commands should map to new style, and keep the 
option git dirty too. Which seems to be broken lately fixing is on my list.  

Current use of these are:
make showversion
4.0-15-gf981d0601907-main

make showrpmversion
4.0_15_gf981d0601907_main

make showdebversion
4.0~15-gf981d0601907-main

>From Tuomo I understand we may need 

"make showrpmrelease"