[Swan-dev] regarding: testing: adding missing : ==== end ==== to nicinit

[Antony Antony]

On Tue, Jan 28, 2020 at 04:59:41PM -0500, Paul Wouters wrote:
> On Tue, 28 Jan 2020, Antony Antony wrote:
> 
> > > I see people using cut and paste and suddenly seeing multiple markers and missing markers. So I prefer to not use it if we can avoid them.
> > 
> > for now I prefer marker over  "netkey-vti-04/final.sh:hostname | grep nic >
> > /dev/null || ipsec whack --trafficstatus"
> 
> I understand that is your preference if _any_ solution is needed. But you
> didn't answer my real question. Is there any test case that functionally
> needs to run final.sh on nic? Do we have a test that is simple enough
> that it uses init/run/final, yet needs to do something on nic in the
> final.sh? Without that current requirement, why would we need to use
> any of these hacks with markers or hostname grepping ? Then we should
> just not run final.sh on nic ever. 

I don't know. If you don't see any they are gone. I was thinking of ocsp.  
Those are changed to numbered scripts.

I was fighting spread of "hostname | grep nic /dev/null || ipsec whack 
--trafficstatus"