[Swan-dev] "check was treating AUTHBY as enum, while it is string, "

Paul Wouters paul at nohats.ca
Tue Jan 28 10:44:10 UTC 2020

Thanks for finding this bug Antony!

I'm sorry you got bitten by this when you merged in the xfrmi branch.

It does prove a point that branches become stale, and re-merging master
into them regularly is a good thing. Then this fallout would have
happened a few months ago.

Although I did do some testing of xfrmi into master during the last
few months, but would then throw away the merge.  And I didn't hit it
because I only tested the branch feature, not a full testrun on the
merged branch. Hopefully now with our low count of failing tests, people
including me are more tempted to run full test runs again on branches
too :)

Thanks again,


---------- Forwarded message ----------
Date: Mon, 27 Jan 2020 13:36:48
From: Antony Antony <antony at vault.libreswan.fi>
To: swan-commit at lists.libreswan.org
Subject: [Swan-commit] Changes to ref refs/heads/master

New commits:
commit f2967f3bffd186192b3e9487219f883e0690863b
Author: Antony Antony <antony at phenome.org>
Date:   Mon Jan 27 18:22:09 2020 +0000

     pluto: fix do not set sighash_policy = NONE when failureshunt was set

     Fixes: 5d2283092dc
     check was treating AUTHBY as enum, while it is string, and checking wrong array.

commit aba50e3a12e3c5a99a3750a436cc50c8574a815c
Author: Antony Antony <antony at phenome.org>
Date:   Sun Jan 26 22:33:32 2020 +0000

     testing: ikev2-x509-38-failureshunt simplify the config

Swan-commit mailing list
Swan-commit at lists.libreswan.org

More information about the Swan-dev mailing list