[Swan-dev] whack_log() or loglog(); Re: [Swan-commit] Changes to ref refs/heads/master

[Paul Wouters]

On Wed, 19 Feb 2020, Andrew Cagney wrote:

>> commit b9c1086c7a86f38e3f4fbc6b596b70d404f22a2a
>> Author: Paul Wouters <pwouters at redhat.com>
>> Date:   Tue Feb 18 14:25:10 2020 -0500
>>
>>     pluto: change two log messages into a whack_log()
>>
>>     side effect, fixes compile without FIPS :P
>
> For show commands whack_log() is right.  However when the whack
> command is trying to modify internal state I think it should always
> leave something in the main log file.
> Currently we can be left with no hint of what did or did not happen.
>
> (the related change is to, when debugging is enabled, write any
> whack-only output to the log file as a debug log so we can again see
> what's going on)

I guess it is not clear at the moment to me what our logging API is.

I was assuming that whack_log() would be the same as logging + whack
message, and not just a whack message. And that the "whack but not log"
for things like status output would be a special whach_log invocation.

Paul