[Swan-dev] impair variable names

Paul Wouters paul at nohats.ca
Wed Apr 1 23:58:59 UTC 2020


Works for me

Sent from my iPhone

> On Apr 1, 2020, at 19:38, Andrew Cagney <andrew.cagney at gmail.com> wrote:
> 
> 
> 
> 
>> On Wed, 1 Apr 2020 at 18:10, Antony Antony <antony at phenome.org> wrote:
>> On Mon, Mar 30, 2020 at 12:07:17PM -0400, Andrew Cagney wrote:
>> > I'm cleaning up the impair code.
>> > 
>> > Internally, the old style #define names are in upper case vis:
>> >   #define IMPAIR_REPLAY_FORWARD ...
>> > and
>> >   IMPAIR(REPLAY_FORWARD)
>> > while the new ones (that take parameters) are in lower case vis:
>> >   extern enum send_impairment impair_ike_key_length_attribute
>> > I've merged the two but preserved the names.
>> > 
>> > Should the names be made consistent?
>> 
>> that would be great.  go for it.
>> 
> 
> so how about:
>   IMPAIR(replay_forward)
> ?
>  
>> thanks,
>> -antony
> _______________________________________________
> Swan-dev mailing list
> Swan-dev at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libreswan.org/pipermail/swan-dev/attachments/20200401/28a39a6a/attachment.html>


More information about the Swan-dev mailing list