<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Works for me<br><br><div dir="ltr">Sent from my iPhone</div><div dir="ltr"><br><blockquote type="cite">On Apr 1, 2020, at 19:38, Andrew Cagney <andrew.cagney@gmail.com> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 1 Apr 2020 at 18:10, Antony Antony <<a href="mailto:antony@phenome.org">antony@phenome.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Mar 30, 2020 at 12:07:17PM -0400, Andrew Cagney wrote:<br>
> I'm cleaning up the impair code.<br>
> <br>
> Internally, the old style #define names are in upper case vis:<br>
> #define IMPAIR_REPLAY_FORWARD ...<br>
> and<br>
> IMPAIR(REPLAY_FORWARD)<br>
> while the new ones (that take parameters) are in lower case vis:<br>
> extern enum send_impairment impair_ike_key_length_attribute<br>
> I've merged the two but preserved the names.<br>
> <br>
> Should the names be made consistent?<br>
<br>
that would be great. go for it.<br>
<br></blockquote><div><br></div><div>so how about:</div><div> IMPAIR(replay_forward)<br></div><div>?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
thanks,<br>
-antony<br>
</blockquote></div></div>
<span>_______________________________________________</span><br><span>Swan-dev mailing list</span><br><span>Swan-dev@lists.libreswan.org</span><br><span>https://lists.libreswan.org/mailman/listinfo/swan-dev</span><br></div></blockquote></body></html>