[Swan-dev] st_peer_wants_null

[Vukasin Karadzic]

Hi all,

сре, 6. феб 2019. у 23:21 D. Hugh Redelmeier <hugh at mimosa.com> је
написао/ла:

> struct state has:
>
>         bool st_peer_wants_null;                /* We received IDr payload
> of type ID_NULL (and we allow POLICY_AUTH_NULL */
>
> This was added in commit 96015a9f0753d21938960b71e0b81f071833d8ed from
> almost a year ago.
>
> This field is tested but never set.
>

It is set in ikev2.c, function
static bool decode_peer_id_counted(struct ike_sa *ike,
                   struct msg_digest *md, int depth) ?


> Of course it is initialized to false when a struct state is created.
>
> It was set in 96015a9f0753d21938960b71e0b81f071833d8ed by
> ikev2_decode_peer_id_and_certs(), something that no longer exists.
>
> Is this a bug in our current code?
>
> - Should we delete code that only executes when st_peer_wants_null is true?
>
> - Should we add code that sets st_peer_wants_null to true?
>
> - Is st_peer_wants_null needed for some feature to be added in the future?
>
> Have I missed something?
> _______________________________________________
> Swan-dev mailing list
> Swan-dev at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libreswan.org/pipermail/swan-dev/attachments/20190206/fb4b7db5/attachment.html>