[Swan-dev] st_peer_wants_null

D. Hugh Redelmeier hugh at mimosa.com
Wed Feb 6 22:21:13 UTC 2019

struct state has:

        bool st_peer_wants_null;		/* We received IDr payload of type ID_NULL (and we allow POLICY_AUTH_NULL */

This was added in commit 96015a9f0753d21938960b71e0b81f071833d8ed from
almost a year ago.

This field is tested but never set.
Of course it is initialized to false when a struct state is created.

It was set in 96015a9f0753d21938960b71e0b81f071833d8ed by
ikev2_decode_peer_id_and_certs(), something that no longer exists.

Is this a bug in our current code?

- Should we delete code that only executes when st_peer_wants_null is true?

- Should we add code that sets st_peer_wants_null to true?

- Is st_peer_wants_null needed for some feature to be added in the future?

Have I missed something?

More information about the Swan-dev mailing list