[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1473600:  Resource leaks  (RESOURCE_LEAK)
/lib/libswan/secrets.c: 1450 in allocate_ECDSA_public_key_nss()


________________________________________________________________________________________________________
*** CID 1473600:  Resource leaks  (RESOURCE_LEAK)
/lib/libswan/secrets.c: 1450 in allocate_ECDSA_public_key_nss()
1444     	keyblobtoid((const unsigned char *)keyid, KEYID_BUF,
1445     		    pk->u.ecdsa.keyid, KEYID_BUF);
1446     
1447     	/* ckaid */
1448     	err_t err =form_ckaid_ecdsa(pub, &ckaid);
1449     	if (err != NULL)
>>>     CID 1473600:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "pk" going out of scope leaks the storage it points to.
1450     		return NULL;
1451     
1452     	pk->u.ecdsa.ckaid = ckaid;
1453     	/*
1454     	 * based on comments in form_keyid, the modulus length
1455     	 * returned by NSS might contain a leading zero and this


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa-2F6FIQzoHE-2FeGfLjPxAHnMmI2-2BcDlBXS8eK3EDO-2F5Fjl6z3ueBPZWbG1BXBakNu80-3D_4HMcbsf14xheNUejmIGHntUcwhwkdYITNaUIUw0xLaoDgBsDvzxQpotjy6-2FL2N9O1QRh5r7-2BjDji0gziDG-2F-2BU4COKUE7xHsKH56y7NOjMEe3lrIL4stazAyk-2Fs1lHVL5fYNCe0flBexB0bpYJ9t3OIJyH9T4IESODoc-2BUZuCXmmf9WSW3dTr5gpQlyYPgHLLhxrnhoB3joGGfFuyDBNtrg-3D-3D

  To manage Coverity Scan email notifications for "antony at phenome.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4T11LJsTCGAu8UQysrZAC89q-2FP-2B3fe1J15ziye5UyoPhoOtByWqcc6ADp6Tx8rz1FuEBlJrervxOcvY4aXgJd53T3KDIOTHFcOCaGp5NkyaQ-3D_4HMcbsf14xheNUejmIGHntUcwhwkdYITNaUIUw0xLaoDgBsDvzxQpotjy6-2FL2N9OaG6B6Wr2-2B49gtuSjCUol-2FxA0mDtf-2FH0W4V6k-2F2ffXsI8JqxFI-2B10bhoMCVHS0WOJ7CqhE9CeZG7KK4u00hUhj8ru5pIVl0sQ6KCliDXer2EvB-2BYSXvdYmkueBL-2BxauuRLW2a2Gx6vVU-2BSME-2BqliMMw-3D-3D