[Swan-dev] checking for printf("%s", NULL) in kvmresults.py

[Andrew Cagney]

Pluto, on occasion, is printing NULL strings, for instance:

$ grep '(null)' testing/pluto/*/OUTPUT/*.pluto.log | grep -e '|' | cut
'-d|' -f2- | sed -e 's/#[0-9]*/#0/g' | sort -u
 child state #0: (null)(ignore) => delete
 I am receiving an IKEv2 Request (null)
 In keys.c, checking OTP filename: (null)
 next payload type: previous 'IKEv2 Encryption Payload' 'next payload
type' matches 'IKEv2 Bogus Payload' (255:(null))
 next payload type: previous 'IKEv2 Identification - Initiator -
Payload' 'next payload type' matches 'IKEv2 Bogus Payload'
(255:(null))
 next payload type: previous 'IKEv2 Notify Payload' 'next payload
type' matches 'IKEv2 Bogus Payload' (255:(null))
 next payload type: previous 'ISAKMP Message' 'next payload type'
matches 'IKEv2 Bogus Payload' (255:(null))
 parent state #0: new => (null)(ignore)

while, thanks to the printf() implementation we rely on, it is mostly
harmless, it's something easy to detect and fix (for instance, using
the right enum lookup function).
The only got-ya is in the algorithm list where '(null)' is valid.

I'll add detecting this as part of running the tests as a TODO.

Andrew