[Swan-dev] a question on whack exit codes (libreswan-up-down.sh)

[Andrew Cagney]

On 9 May 2018 at 13:45, Paul Wouters <paul at nohats.ca> wrote:
> On Wed, 9 May 2018, Andrew Cagney wrote:
>
>>> Can you elaborate? I do think it fixed something, but you might run into
>>> other messages using a wrong RC_* code ?
>>
>>
>> In this test:
>>
>>
>> http://testing.libreswan.org/results/v3.22-1343-g648051a-master/ikev2-unknown-payload-03-auth-sk/OUTPUT/west.console.diff
>>
>> The 'ipsec auto --up <connection>' didn't establish - something
>> screwed up so it is retrying in the background.
>>
>> Previously, the exit code would have been non zero, but now it is
>> zero.  However, ...
>
>
> Right, but in this case we really don't know if the outcome is going
> to be an error or not. So better to not return an error code
> prematurely.

Yea.   I pushed my change so that  whack --trafficstatus is used to
determine if the connection came up.