[Swan-dev] crash after pluto: Fix addresspool reference count

[Paul Wouters]

On Thu, 5 Oct 2017, Wolfgang Nothdurft wrote:

>> An addresspool is shared between connections. Eech connection add on
>> sreference count. I think a connection instance may also add a reference
>> count, I am not sure any more.
>> 
>> Lease should not add reference count to the pool. Atleast that is the idea.
>> 
>> I will look into soon, probably tomorrow.
>> 
>
> ah ok, than it is easy. Than the unreference call is wrong and should only be 
> called when the non-instance connection is deleted.
>
> I have updated lsw#299 with the final patch.

I've reverted the previous patch, then tested with this patch only. It
did not cause regression for me. So if Antony is fine with it, we can
merge this last patch in.

xauth-pluto-18 does show the misconfiguration crasher, but that seems to
happen regardless of this patch.

Paul