[Swan-dev] state m/c 2of3: State machine cleanups

Paul Wouters paul at nohats.ca
Wed Mar 4 07:33:26 EET 2015

On Tue, 3 Mar 2015, Andrew Cagney wrote:

> The enum is:
> enum phase1_role {
>        O_INITIATOR=1,
>        O_RESPONDER=2
> };

That could prob use a rename too :P Maybe origin_role ?

> so st->st_o_role (and a renamed) md->o_role wouldn't be out of place.

_o_ looks a little silly? :)

> My preference is actually for st_original_role / md->original_role.  I
> chose st_role to match md->role.

How about st_origin_r ? or st_origin_role with md->origin(_role)

Mostly st_original_role is a bit long and we have the 80 chars police :P


More information about the Swan-dev mailing list