[Swan-dev] state m/c 2of3: State machine cleanups

[Andrew Cagney]

On 4 March 2015 at 00:33, Paul Wouters <paul at nohats.ca> wrote:

> On Tue, 3 Mar 2015, Andrew Cagney wrote:
>
>  The enum is:
>>
>> enum phase1_role {
>>        O_INITIATOR=1,
>>        O_RESPONDER=2
>> };
>>
>
> That could prob use a rename too :P Maybe origin_role ?
>
>  so st->st_o_role (and a renamed) md->o_role wouldn't be out of place.
>>
>
> _o_ looks a little silly? :)
>

yes.


>  My preference is actually for st_original_role / md->original_role.  I
>> chose st_role to match md->role.
>>
>
> How about st_origin_r ? or st_origin_role with md->origin(_role)
>
> Mostly st_original_role is a bit long and we have the 80 chars police :P
>
>
>
On the other hand  "original Initiator" and "original responder" (including
quotes) are found in the RFC so its easy to align the code with the spec.
Think of 80 as more guidance, and generally stick to 70.

Andrew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libreswan.org/pipermail/swan-dev/attachments/20150304/9ad0af22/attachment.html>