[Swan-dev] spacers in flag names: - or _?

[D. Hugh Redelmeier]

| From: Paul Wouters <paul at vault.libreswan.fi>

| commit a0f5b2688533d43556655200e501e72a17a4b957
| Author: Paul Wouters <pwouters at redhat.com>
| Date:   Sun Apr 13 19:50:19 2014 -0400
| 
|     pluto: turn -DLEAK_DETECTIVE into runtime --leak_detective option.

Most flags that need a spacer use "-".  Some newer ones use "_".  This
is confusing and non-standard.

I checked the pluto flags (not whack or anything else)
- 43 use "-"
- 10 use "_"
- debug-nat_t is in both counts.

I think that "normal" programs use "-".

I propose that all spacers within flags be "-".

Here's what would change:
    leak_detective
    force_busy
    ipsec_dir
    nat_traversal
    keep_alive  <<== should agree
    force_keepalive  <== on spelling of keep alive
    disable_port_floating
    debug-nat_t
    virtual_private
    secctx_attr_value