[Swan] KLIPS pfkey_create kernel oops v3.17

[Ofer Heifetz]

Hi Paul,

The fix I sent to list was just to make KLIPS stop crashing my kernel, it was not a final fix since it overwrote sock parameter skc_daddr: Foreign IPv4 addr, so I changed my fix to save the key_pid into the void * sk_user_data, seems like a better alternative.

/Ofer

-----Original Message-----
From: Paul Wouters [mailto:paul at nohats.ca] 
Sent: Monday, May 30, 2016 6:36 PM
To: Ofer Heifetz <oferh at marvell.com>
Cc: swan at lists.libreswan.org
Subject: Re: [Swan] KLIPS pfkey_create kernel oops v3.17

On Fri, 27 May 2016, Ofer Heifetz wrote:

> To overcome this I simply changed the :
> # define key_pid(sk) ((struct key_opt*)&(sk))->key_pid
> To:
> # define key_pid(sk) ((struct key_opt*)(sk))->key_pid
>
> key_pid should be saved in sock struct w/o overwriting a valuable field.

Thanks for the patch, will be in 3.18.

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-KLIPS-fix-sk-pointer-usage-for-key_pid.patch
Type: application/octet-stream
Size: 1086 bytes
Desc: 0001-KLIPS-fix-sk-pointer-usage-for-key_pid.patch
URL: <https://lists.libreswan.org/pipermail/swan/attachments/20160530/0856040d/attachment-0001.obj>