[Swan] Crash with Libreswan 3.11

[Paul Wouters]

On Tue, 4 Nov 2014, Roel van Meer wrote:

>> I've tried several versions of Libreswan (3.8, 3.9, 3.11) and two versions 
>> of mozilla-nss (3.13.5, 3.16.5), but the crash is seen in all combinations.
>
> I've now also tried with nss-3.17.2, but that has the same result.
>
> Together with a colleague I added some null pointer checks to nss (see the 
> attached patch). When we do that, the crash disappears as such, but now we 
> hit a failed assert:

It looks like some corruption happened, and we were giving nonsense to
nss. Your passert patch seems to confirm that.

> I hope this is useful. Please let me know if I can provide any more 
> information, or if there is anything I should test.

If possible, you could enable EFENCE in Makefile.inc and compile with
electric fence. It might be able to spot some bad memory usage.

Paul