[Swan] initial thoughts on uncrustifying libreswan

Lennart Sorensen lsorense at csclub.uwaterloo.ca
Fri May 24 17:42:46 EEST 2013


On Fri, May 24, 2013 at 10:12:05AM -0400, Paul Wouters wrote:
> I never claimed my rules were logical :) In some sense when you add
> variables, you are about to do something that stands on its on. I think
> it is a left over from old days where you couldn't declare variables
> midway, and had to start a new block. I do like using braces to denote
> a block of work.

But there is nothing wrong with:

	if (foo) {
		int i;

		for (i=0; i<5; i++) {
			code;
		}
		more code;
	}

And no exceptions to rules that way.

Simpler to have a rule of: Opening braces go on the same line as the
control for them.

Having 'except if we decalre new variables, or if the control code
needed a line break, or some other exception' just makes it harder to
get consistent and adds nothing of value.

Now if you happen to need to do:

	code;
	more code;
	{
		int i;

		for (i=0; i<5; i++) {
			code;
		}
	}

well then I just question what you are doing.

-- 
Len Sorensen


More information about the Swan mailing list