[Swan] initial thoughts on uncrustifying libreswan

Paul Wouters pwouters at redhat.com
Fri May 24 17:14:10 EEST 2013


On Fri, 24 May 2013, Lennart Sorensen wrote:

>> but use braces on their own line when the block is introducing new
>> variables.
>>
>> 	if (foo)
>> 	{
>> 		struct thing;
>>
>> 		thing = alloc_bytes(foo, "stuff");
>> 		[...]
>> 	}
>
> Why make an exception?  Now if you come along and need to add a new
> variable to a block later, you have to move the braces to follow some
> weird arbitrary exception?  Why make it different?

I agree it is not needed. I prefer it but I'm happy to go for
consistency and give it up.

> I never have understood why the kernel style puts the '{' on a new line
> for function declarations, but not for other places.

I think that has all to do with emacs/vim and quick code navigation.

Paul


More information about the Swan mailing list