[Swan] zlib

Paul Wouters pwouters at redhat.com
Fri May 24 00:42:39 EEST 2013


On Thu, 23 May 2013, D. Hugh Redelmeier wrote:

> The uncrustify changes were backed out for libreswan's copy of zlib.  I
> can only guess why (not really our code?).
>
> Why do we even have a zlib?  Surely there are already copies in the
> kernel?

I already have a pending patch that puts #ifdef __KERNEL__ around it to
ensure userland does not use it. Currently, it does not. Only KLIPS uses
it.

> If we have to have our own, why is it not at least somewhat segregated
> from the rest of the code (say, in a subdirectory)?

Yes we could. ideally, we use the zlib code of the kernel and get rid of
all of the below files.

Paul

> Based on the back-out commit, this is the list of files from zlib:
>    libreswan/linux/net/ipsec/adler32.c
>    libreswan/linux/net/ipsec/deflate.c
>    libreswan/linux/net/ipsec/deflate.h
>    libreswan/linux/net/ipsec/infblock.c
>    libreswan/linux/net/ipsec/infblock.h
>    libreswan/linux/net/ipsec/infcodes.c
>    libreswan/linux/net/ipsec/infcodes.h
>    libreswan/linux/net/ipsec/inffast.c
>    libreswan/linux/net/ipsec/inffast.h
>    libreswan/linux/net/ipsec/inffixed.h
>    libreswan/linux/net/ipsec/inflate.c
>    libreswan/linux/net/ipsec/inftrees.c
>    libreswan/linux/net/ipsec/inftrees.h
>    libreswan/linux/net/ipsec/infutil.c
>    libreswan/linux/net/ipsec/infutil.h
>    libreswan/linux/net/ipsec/trees.c
>    libreswan/linux/net/ipsec/trees.h
>    libreswan/linux/net/ipsec/zutil.c
> _______________________________________________
> Swan mailing list
> Swan at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan
>


More information about the Swan mailing list