[Swan] Phasing out #ifdef DEBUG ?

[Paul Wouters]

I've done this in the past, but I ran another test to see what the
difference is between compiling with DBUG and without DEBUG. As
previously, compiling without DEBUG does not work out of the box,
and requires fixing again. I did a quick hack to make it compile
and the results are:

text	   data	    bss	    dec	    hex	filename
832327	  82368	 124672	1039367	  fdc07 OBJ.linux.x86_64/programs/pluto/pluto

text	   data	    bss	    dec	    hex	filename
937621	  84408	 124672	1146701	 117f4d OBJ.linux.x86_64/programs/pluto/pluto

So about 10%

Compare this to now requiring NSS:

text	   data	    bss	    dec	    hex	filename
1253845	  26176	   6024	1286045	 139f9d /usr/lib64/libnss3.so

And libunbound (for DNSSEC):

text	   data	    bss	    dec	    hex	filename
674637	  20240	   1856	 696733	  aa19d	/usr/lib64/libunbound.so

Therefor, I propose to phase out #ifdef DEBUG, and always compile the
debug code in.

Paul