[Swan] threading issue located

Philippe Vouters philippe.vouters at laposte.net
Fri Mar 8 18:19:28 EET 2013


Paul,

Do consider all the variables declared at outer level in 
programs/pluto/log.c. Some of them (the non const variables) should make 
the code non re-entrant. Hence it now works by protecting code sequences 
with a mutex.

Regards,

Philippe Vouters (Fontainebleau/France)
URL: http://vouters.dyndns.org/
SIP: sip:Vouters at sip.linphone.org

Le 08/03/2013 16:51, Paul Wouters a écrit :
>
> Hi,
>
> Just a follow up for the record.
>
> Adding pthread mutex locks to programs/pluto/log.c functions:
>
> libreswan_log()
> DBG_log()
> loglog()
>
> seems to stop crashers from happening in the system's syslog() call.
>
> Clearly this is just a work around and we should look at which functions
> called there are not re-entrant and fix those. Additionally, we have
> copies of those functions (unfortunately) in lib/libswan, where they
> should probably be fixed as well.
>
> Thanks to Philippe for pointing me in the right direction to test this,
>
> Paul
> _______________________________________________
> Swan mailing list
> Swan at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan
>



More information about the Swan mailing list