<div dir="ltr">Ah, yes.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 4 May 2021 at 00:45, D. Hugh Redelmeier <<a href="mailto:hugh@mimosa.com">hugh@mimosa.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">| From: <a href="mailto:scan-admin@coverity.com" target="_blank">scan-admin@coverity.com</a><br>
<br>
| ________________________________________________________________________________________________________<br>
| *** CID 1504581:  Incorrect expression  (COPY_PASTE_ERROR)<br>
| /testing/programs/ipcheck/ip_range_check.c: 395 in check_range_op_range()<br>
| 389                                   FAIL("ttorange(%s) failed: %s", t->R, oops); \<br>
| 390                           }                                               \<br>
| 391                   } else {                                                \<br>
| 392                           l = unset_range;                                \<br>
| 393                   }<br>
| 394                   TT(l);<br>
| >>>     CID 1504581:  Incorrect expression  (COPY_PASTE_ERROR)<br>
| >>>     "l" in "l = unset_range" looks like a copy-paste error.<br>
| 395                   TT(r);<br>
| 396     #undef TT<br>
| 397     <br>
| 398     #define T(OP,L,R)                                                     \<br>
| 399                   {                                                       \<br>
| 400                           bool cond = OP(L,R);                            \<br>
| <br>
| ** CID 1504580:    (UNREACHABLE)<br>
| /testing/programs/ipcheck/ip_address_check.c: 396 in check_addresses_to()<br>
| /testing/programs/ipcheck/ip_address_check.c: 403 in check_addresses_to()<br>
<br>
I'm not sure what it is complaining about but I think it might be<br>
right.<br>
<br>
Cagney: does this fix look correct?<br>
<br>
diff --git a/testing/programs/ipcheck/ip_range_check.c b/testing/programs/ipcheck/ip_range_check.c<br>
index 256cf76c70..9f9a27db58 100644<br>
--- a/testing/programs/ipcheck/ip_range_check.c<br>
+++ b/testing/programs/ipcheck/ip_range_check.c<br>
@@ -389,7 +389,7 @@ static void check_range_op_range(void)<br>
                                FAIL("ttorange(%s) failed: %s", t->R, oops); \<br>
                        }                                               \<br>
                } else {                                                \<br>
-                       l = unset_range;                                \<br>
+                       R = unset_range;                                \<br>
                }<br>
                TT(l);<br>
                TT(r);<br>
_______________________________________________<br>
Swan-dev mailing list<br>
<a href="mailto:Swan-dev@lists.libreswan.org" target="_blank">Swan-dev@lists.libreswan.org</a><br>
<a href="https://lists.libreswan.org/mailman/listinfo/swan-dev" rel="noreferrer" target="_blank">https://lists.libreswan.org/mailman/listinfo/swan-dev</a><br>
</blockquote></div>