<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><br><div dir="ltr"><br>Begin forwarded message:<br><br></div><blockquote type="cite"><div dir="ltr"><b>From:</b> Andrew Cagney <cagney@vault.libreswan.fi><br><b>Date:</b> March 9, 2020 at 11:32:17 EDT<br><b>To:</b> swan-commit@lists.libreswan.org<br><b>Subject:</b> <b>[Swan-commit] Changes to ref refs/heads/master</b><br><b>Reply-To:</b> swan-dev@lists.libreswan.org<br><br></div></blockquote><blockquote type="cite"><div dir="ltr"><span>New commits:</span><br><span>commit 7a7224b0e2381c416decb1d08bc191cd9fd783f1</span><br><span>Author: Andrew Cagney <cagney@gnu.org></span><br><span>Date:   Mon Mar 9 11:27:01 2020 -0400</span><br><span></span><br><span>    ikev2: rename enum notify_payload_hash_algorithms to enum ikev2_hash_algorithm</span></div></blockquote><div><br></div><div>This is confusing. We have an IANA registry for ikev2 hash (integ) algorithms and this is not it.</div><div><br></div><div>See:</div><div><br></div><div><a href="https://www.iana.org/assignments/ikev2-parameters/ikev2-parameters.xhtml#ikev2-parameters-7">https://www.iana.org/assignments/ikev2-parameters/ikev2-parameters.xhtml#ikev2-parameters-7</a></div><div><br></div><div>Versus:</div><div><br></div><div><a href="https://www.iana.org/assignments/ikev2-parameters/ikev2-parameters.xhtml#hash-algorithms">https://www.iana.org/assignments/ikev2-parameters/ikev2-parameters.xhtml#hash-algorithms</a></div><div><br></div><div>The first is a transform type, the second is a notify value. Better name would be ikev2_rfc7427_hash_algo ?</div><div><br></div><div>I fear ikev2_hash_algorithm is prone to be misused as a transform value.</div><div><br></div><div>Paul</div><div><br></div><div><br></div><div><br></div></body></html>