<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 29 Jul 2019 at 08:38, Andrew Cagney <<a href="mailto:andrew.cagney@gmail.com">andrew.cagney@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">These make variables should only be expanded when web pages are enabled?  Per the comment:<div><br></div><div># shortcuts to use when web is enabled, set up to evaluate once as<br># they can be a little expensive.  These make variable can only be<br># used inside of WEB_ENABLED blocks.</div></div></blockquote><div><br></div><div>In fact it was working.  Here's what happens in my tree using the commit just before the below:<br></div><div><div class="gmail_quote"><div><br></div><div>$ v=$(gmake showversion)</div><div>$ echo $v</div><div>3.28-506-g423d0e04bd-HEAD</div>$ v=$(make showversion LSW_WEBDIR=..)<br>+ cd .<br>+ git show --no-patch --format=%H HEAD<br>+ testing/web/gime-git-description.sh .<br></div><div class="gmail_quote">$ echo $v</div><div class="gmail_quote">3.28-506-g423d0e04bd-HEAD</div><div class="gmail_quote">$</div><div class="gmail_quote"><br></div><div class="gmail_quote">so I'm stumped as to why the below behaviour occurred.</div><div class="gmail_quote"><br></div><div class="gmail_quote">Andrew</div><div class="gmail_quote"><br></div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>At one point they were very expensive, unconditionally expanded, and repeatedly making everything slow.  Hence their verbosity - so we can see if the bug has crept back in</div><div>(from memory, most of the expense was in computing 'dirty' which is why the web page code doesn't do that)</div><div><br></div><div>Andrew</div><div><br></div><div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">---------- Forwarded message ---------<br>From: <b class="gmail_sendername" dir="auto">Antony Antony</b> <span dir="auto"><<a href="mailto:antony@vault.libreswan.fi" target="_blank">antony@vault.libreswan.fi</a>></span><br>Date: Mon, 29 Jul 2019 at 08:01<br>Subject: [Swan-commit] Changes to ref refs/heads/master<br>To:  <<a href="mailto:swan-commit@lists.libreswan.org" target="_blank">swan-commit@lists.libreswan.org</a>><br></div><br><br>New commits:<br>
commit 367867e7124949f029c5bf0b3b0f527384770bad<br>
Author: Antony Antony <<a href="mailto:antony@phenome.org" target="_blank">antony@phenome.org</a>><br>
Date:   Sun Jul 21 11:08:10 2019 +0000<br>
<br>
    testing: remove set -x from <a href="http://web-targets.mk" rel="noreferrer" target="_blank">web-targets.mk</a><br>
<br>
    after:<br>
    make showversion<br>
    3.28-504-g5113b92b34-master<br>
<br>
    before:<br>
    make showversion<br>
    + cd .<br>
    + git show --no-patch --format=%H HEAD<br>
    + testing/web/gime-git-description.sh .<br>
    3.28-504-g5113b92b34-dirty-master<br>
<br>
_______________________________________________<br>
Swan-commit mailing list<br>
<a href="mailto:Swan-commit@lists.libreswan.org" target="_blank">Swan-commit@lists.libreswan.org</a><br>
<a href="https://lists.libreswan.org/mailman/listinfo/swan-commit" rel="noreferrer" target="_blank">https://lists.libreswan.org/mailman/listinfo/swan-commit</a><br>
</div></div></div>
</blockquote></div></div>