<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><br><br><div id="AppleMailSignature" dir="ltr">regards,<div>-antony</div><div><br></div></div><div dir="ltr"><br>Begin forwarded message:<br><br></div><blockquote type="cite"><div dir="ltr"><b>From:</b> <a href="mailto:scan-admin@coverity.com">scan-admin@coverity.com</a><br><b>Date:</b> September 27, 2018 at 10:10:29 GMT+2<br><b>To:</b> <a href="mailto:antony@phenome.org">antony@phenome.org</a><br><b>Subject:</b> <b>New Defects reported by Coverity Scan for antonyantony/libreswan</b><br><br></div></blockquote><blockquote type="cite"><div dir="ltr"><span>Hi,</span><br><span></span><br><span>Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.</span><br><span></span><br><span>1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.</span><br><span></span><br><span></span><br><span>New defect(s) Reported-by: Coverity Scan</span><br><span>Showing 1 of 1 defect(s)</span><br><span></span><br><span></span><br><span>** CID 1473687:  Control flow issues  (DEADCODE)</span><br><span>/programs/pluto/ikev2_spdb_struct.c: 1267 in emit_transform()</span><br><span></span><br><span></span><br><span>________________________________________________________________________________________________________</span><br><span>*** CID 1473687:  Control flow issues  (DEADCODE)</span><br><span>/programs/pluto/ikev2_spdb_struct.c: 1267 in emit_transform()</span><br><span>1261                 if (!v2_out_attr_fixed(IKEv2_KEY_LENGTH, transform->attr_keylen, &trans_pbs)) {</span><br><span>1262                     return false;</span><br><span>1263                 }</span><br><span>1264             }</span><br><span>1265         } else  {</span><br><span>1266             switch (impair_key_length_attribute) {</span><br><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>    CID 1473687:  Control flow issues  (DEADCODE)</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>    Execution cannot reach this statement: "case SEND_NORMAL:".</span><br></blockquote></blockquote></blockquote><span>1267             case SEND_NORMAL:</span><br><span>1268                 PASSERT_FAIL("%s", "should have been handled");</span><br><span>1269                 break;</span><br><span>1270             case SEND_EMPTY:</span><br><span>1271                 libreswan_log("IMPAIR: emitting variable-size key-length attribute with no key");</span><br><span>1272                 if (!v2_out_attr_variable(IKEv2_KEY_LENGTH, empty_chunk, &trans_pbs)) {</span><br><br></div></blockquote></body></html>