<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 5 October 2017 at 15:23, Paul Wouters <span dir="ltr"><<a href="mailto:paul@nohats.ca" target="_blank">paul@nohats.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On Thu, 5 Oct 2017, Antony Antony wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
--impair ... now works?<br>
</blockquote>
<br>
what I added is<br>
<br>
ipsec whack --debug-all --impair drop-xauth-r0<br>
<br>
ipsec whack --impair-drop-xauth-r0 do not work.<br>
unrecognized option '--impair-drop-xauth-r0'<br>
<br></blockquote></span></blockquote><div><br></div><div>That's because it was called --impair-drop-no-xauth-r0 when added to whack:<br></div><div><br></div><div>index 74ec5bd03..df9684004 100644<br>--- a/programs/whack/whack.c<br>+++ b/programs/whack/whack.c<br>@@ -786,6 +786,8 @@ static const struct option long_opts[] = {<br> IMPAIR_SEND_NO_IKEV2_AUTH_IX + DO },<br> { "impair-send-no-xauth-r0", no_argument, NULL,<br> IMPAIR_SEND_NO_XAUTH_R0_IX + DO },<br>+ { "impair-drop-no-xauth-r0", no_argument, NULL,<br>+ IMPAIR_DROP_XAUTH_R0_IX + DO },<br> { "impair-send-no-main-r2", no_argument, NULL,<br> IMPAIR_SEND_NO_MAIN_R2_IX + DO },<br> /* <br></div><div><br></div>the reason I added --impair ... and --debug ... was because I found the duplication redundant and somewhat error proned<br></div><div class="gmail_quote"><br><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I am confused why we have two methods. When I looked enumcheck-01 had other<br>
unknown changes, so I didn't commit. It seems you are saying enumcheck-01<br>
should have noticed me adding --impair drop-xauth-r0?<br>
<br>
What need fixing? May we should allow only one method.<br>
</blockquote>
<br></span></blockquote><div><br></div><div>enumcheck validates and dumps the enum tables, including this one so the changed output needs a review and update<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-"></span>
I'm also unsure why there are two methods. Or what was wrong with the<br>
first one. I understood it was split off from debug, which is good so<br>
we can presumably run the impair without causing modified debug levels,<br>
which means we can remove the --debug-all from all impair calls. Whether<br>
there is a minus or a space doesn't matter to me, as long as it is<br>
obvious how to specify multiple impairs.<br></blockquote><div><br></div><div> Unfortunately:</div><div><br></div><div> --debug-all --impair ...</div><div><br></div><div>is still needed. Fixing that gets more invasive. While I suspect we can get away with sending separate debug and impair lset_t-s over the wire and then have pluto merge the updates, I'm speculating.<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Since impair should never be used in production, there is no reason to<br>
keep an old API around. So please kill one of the two.<span class="gmail-HOEnZb"><font color="#888888"></font></span></blockquote><div><br></div><div><br></div><div>I figured that for both the existing --impair-... and --debug-* ... options we should leave leave them (including some broken names), but encourage the use of the cleaner --impair and --debug ... implementation on new options.</div><div><br></div><div>Since --impair is conisidered strictly internal, I'll remove them.</div><div><br></div><div>Andrew</div><div><br></div><div> <br></div></div></div></div>