<div dir="ltr"><div><div><div>The additional checks are:<br><br>            check_console_log_for &#39;^CORE FOUND&#39;<br>            check_console_log_for SEGFAULT<br>            check_console_log_for GPFAULT<br>            check_pluto_log_for &#39;ASSERTION FAILED&#39;<br>            check_pluto_log_for &#39;EXPECTATION FAILED&#39;<br>            # this blats CORE into all the .diff files; better than nothing<br>            for i in OUTPUT/core* ; do<br>                if [ -f &quot;$i&quot; ] ; then<br>                    echo &quot;# CORE: $i&quot;<br>                    echo &quot;$i &quot; &gt;&gt; OUTPUT/${host}.console.tmp<br>                fi<br></div><div>            done<br><br>they were lifted from &quot;grep_4_known_errors&quot; in swantest.  pluto-testlist-scan.sh also does similar tests.<br><br></div><div>Are any of these expected?<br></div><div><br></div></div>Andrew<br><br></div>(I had a test get an assertion-failed during exit so it didn&#39;t show up in the console log&#39;s diff)<br><div><div><div><div><br><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 25 May 2015 at 17:25, Paul Wouters <span dir="ltr">&lt;<a href="mailto:paul@nohats.ca" target="_blank">paul@nohats.ca</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, 25 May 2015, Andrew Cagney wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
commit b6b982ab03c5e15c87f4ce0ccedae7a687ccc403<br>
Author: Andrew Cagney &lt;<a href="mailto:cagney@gnu.org" target="_blank">cagney@gnu.org</a>&gt;<br>
Date:   Mon May 25 14:44:58 2015 -0400<br>
<br>
   testing: check console and pluto logs for error messages<br>
<br>
   And put them into the .diff file so failures can be spotted.<br>
</blockquote>
<br>
I&#39;m not sure I like this. There are a few tests that specifically<br>
look for certain errors by grepping their /tmp/pluto.log files.<br>
<br>
I&#39;m afraid this will lead to false positives and more writing of<br>
sanitizers.<br>
<br>
Paul<br>
_______________________________________________<br>
Swan-dev mailing list<br>
<a href="mailto:Swan-dev@lists.libreswan.org" target="_blank">Swan-dev@lists.libreswan.org</a><br>
<a href="https://lists.libreswan.org/mailman/listinfo/swan-dev" target="_blank">https://lists.libreswan.org/mailman/listinfo/swan-dev</a><br>
</blockquote></div><br></div></div></div>