<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 3 March 2015 at 14:52, Antony Antony <span dir="ltr"><<a href="mailto:antony@phenome.org" target="_blank">antony@phenome.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>On Tue, Mar 03, 2015 at 02:39:12PM -0500, Andrew Cagney wrote:<br>
> On 3 March 2015 at 14:08, Paul Wouters <<a href="mailto:paul@nohats.ca" target="_blank">paul@nohats.ca</a>> wrote:<br>
> > On Tue, 3 Mar 2015, Antony Antony wrote:<br>
> ><br>
> >> can you push this change to a branch first? and do test run?<br>
> ><br>
> ><br>
> > Yes that would be good for now.<br>
> ><br>
> >> Also if you push to a branch do you mind if add some changes to it?<br>
><br>
> I was planning on running:<br>
><br>
> find * -type f -print | xargs -1 sed -i<br>
> s/STATE_PARENT_I1/STATE_V2_INIT_I/g ...<br>
><br>
> so everything, including pluto_constans.h, gets updated (things won't<br>
> compile if it doesn't).<br>
><br>
> However, beyond a sniff test (ikev2-05-basic), I'm not sure if there<br>
> is benefit in either creating a branch or running a full testsuite.<br>
<br></span></blockquote><div><br><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>
</span>There are details to take care STATE_IKESA_DEL, and drift in test console output.<br>
So I think it is more than 'a' sed line. Unless you want to dump that fixing console work on others:)<br>
libreswan/testing/pluto (master)$ grep STATE_PARENT */*<br>
<br></blockquote><div><br>Hmm, there's seems to be something going very wrong here. We've essentially got a
black-box testsuite. It shoudn't even be trying to verify nitty-gritty internals such as the names of states and state transitions. This isn't to say that there shouldn't be a test to verify state names/transitions, just not every single test.<br><br></div><div>I'll push a sanitizer to remove these internals by default.<br></div><div><br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
runing full test run is a good idea. See STATE_PARENT in console output<br>
<span><font color="#888888"><br>
-antony<br>
</font></span></blockquote></div><br></div></div>