<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 4 March 2015 at 00:33, Paul Wouters <span dir="ltr"><<a href="mailto:paul@nohats.ca" target="_blank">paul@nohats.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, 3 Mar 2015, Andrew Cagney wrote:<br>
<br>
</span><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The enum is:<br>
<br>
enum phase1_role {<br>
O_INITIATOR=1,<br>
O_RESPONDER=2<br>
};<br>
</blockquote>
<br></span>
That could prob use a rename too :P Maybe origin_role ?<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
so st->st_o_role (and a renamed) md->o_role wouldn't be out of place.<br>
</blockquote>
<br></span>
_o_ looks a little silly? :)<span class=""><br></span></blockquote><div><br></div><div>yes.<br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
My preference is actually for st_original_role / md->original_role. I<br>
chose st_role to match md->role.<br>
</blockquote>
<br></span>
How about st_origin_r ? or st_origin_role with md->origin(_role)<br>
<br>
Mostly st_original_role is a bit long and we have the 80 chars police :P<span class="HOEnZb"><font color="#888888"><br>
<br>
<br></font></span></blockquote><div><br></div><div>On the other hand "original Initiator" and "original responder" (including quotes) are found in the RFC so its easy to align the code with the spec. Think of 80 as more guidance, and generally stick to 70.<br><br></div><div>Andrew<br></div></div><br></div></div>