<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 18 February 2015 at 15:35, Paul Wouters <span dir="ltr"><<a href="mailto:paul@nohats.ca" target="_blank">paul@nohats.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, 18 Feb 2015, Antony Antony wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Subject: Re: [Swan-dev] replace "make check UPDATEONLY=1" with "make update"<span class=""><br>
<br>
my 100% wish.<br>
<br>
make kvmprograms<br>
make kvmprograms install<br>
make kvmmodules<br>
make kvmmodules install<br></span></blockquote></blockquote><div><br></div><div>As a first step I'll add:<br></div><br><div>$ make kvm-update<br><br></div><div>target to the top-level (it will support --sourcedir). That way we've something concrete we can refer to. The existing "make update UPDATEONLY=1" will be left alone.<br><br></div><div>Once the build system reliable, and everyone's had the chance to play with this, we can look at some refinement.<br><br></div><div>BTW, I'm not sure if we'll ever have a target as generic as:<br></div><div><br></div><div>kvm-%:<br></div><div> ./testing/utils/runkvm.py --run "make %*"<br><br></div><div>as:<br></div><div><br></div><div>- it needs the correct timeout for "%*" (perhaps infinite timeout?)<br></div><div>- per swan-update, we still don't trust clean and dependencies<br></div><div>- it needs to know the host (or hosts)<br></div><div><br></div><div>but we can probably get close<br></div><div><br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
</span></blockquote>
<br>
Works for me too. I guess it is better in case we have more docker tests<br>
and "make check" is confusing about which testing system is used.<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
make kvmrpm=libreswan-3.12.rpm install<br>
</blockquote>
<br>
That needs more talk. It's not a valid rpm version and I'm not sure what<br>
you mean to do with this command.<span class=""><br>
<br></span></blockquote><div><br></div><div>I'm assuming the intent is to run "rpm" on all the kvms so that the custom libreswan is installed. I could use this :-)<br>However, initially something like:<br></div><div><br></div><div> $ make kvm-run RUN="rpm -u libreswan-3.12.rpm" HOST="west"<br><br></div><div>which would be syntactic sugar for:<br><br></div><div> ./testing/utils/runkvm.py --sourcedir <magic> --run "rpm -u libreswan.rpm" --host west<br></div><div><br></div><div>might be useful.<br></div><div><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I am also wondering if it is worth to able to pass options to swantest<br>
make check [options] and the options are passed to "swantest"<br>
</blockquote>
<br></span>
That would be nice, if we can tell it to only run v6 or interop or ikev2<br>
or gcm tests.<span class=""><font color="#888888"><br>
<br>
Paul<br>
</font></span></blockquote></div><br></div></div>