[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

scan-admin at coverity.com scan-admin at coverity.com
Fri Apr 7 13:51:21 EEST 2023


Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

2 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1537184:  Null pointer dereferences  (FORWARD_NULL)
/programs/pluto/kernel.c: 1233 in unrouted_to_routed_sec_label()


________________________________________________________________________________________________________
*** CID 1537184:  Null pointer dereferences  (FORWARD_NULL)
/programs/pluto/kernel.c: 1233 in unrouted_to_routed_sec_label()
1227     	}
1228     }
1229     
1230     bool unrouted_to_routed_sec_label(struct connection *c, struct logger *logger)
1231     {
1232     	connection_buf cb;
>>>     CID 1537184:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dereferencing null pointer "c".
1233     	ldbg(logger,
1234     	     "kernel: %s() "PRI_CO" "PRI_CO" "PRI_CONNECTION" routed %s sec_label="PRI_SHUNK,
1235     	     __func__,
1236     	     pri_connection_co(c),
1237     	     pri_connection_co(c->clonedfrom),
1238     	     pri_connection(c, &cb),

** CID 1537183:  Possible Control flow issues  (DEADCODE)
/programs/pluto/kernel_policy.c: 503 in install_inbound_ipsec_kernel_policy()


________________________________________________________________________________________________________
*** CID 1537183:  Possible Control flow issues  (DEADCODE)
/programs/pluto/kernel_policy.c: 503 in install_inbound_ipsec_kernel_policy()
497     #if defined(HAVE_NFTABLES)
498     	bool has_cat = spd->local->child->has_cat;
499     #else
500     	bool has_cat = false;
501     #endif
502     	if (has_cat) {
>>>     CID 1537183:  Possible Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "add_cat_kernel_policy(&kern...".
503     		add_cat_kernel_policy(&kernel_policy, DIRECTION_INBOUND,
504     				      child->sa.st_logger, where,
505     				      "CAT: add inbound IPsec policy");
506     	}
507     
508     	if (!kernel_ops_policy_add(KERNEL_POLICY_OP_ADD,


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYq7Zj_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2FgcXk9TJBF9Ey-2FoRyJcqSwvMZFE4CPeW2z-2BgqlPkujAr-2BluOd65H9nbKm5ciZAnwlZ-2FEBHkzPw6ruin18UnvADEZ-2FbOlXjJ8gh3DJ0-2B5plQc4tiUB2vm0sFUYSdIjkfGZ6D4TXbK2ylIxPF-2BCaxsHVw9Z3aAs3Yofvio8UKKxtSNSojca-2F0PIfcjKKbQOoGko-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxiGyxi_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2FgcXk9TJBF9Ey-2FoRyJcqSwvMZFE4CPeW2z-2BgqlPkujAlRL-2Fa6fHxRyR6tvKkkz1r5L-2Fs2ITilraHinTKKye6xskxBT526vQ73R5bD4p2VwS0ooLy13uW7Vr5QIFkkos5JQXOzvusy2fcyBQAALBPg9-2FCLqaMcO8Dx4NgwPb7T9l4QLQMptYEAREVtdCwCyomA-3D



More information about the Swan-dev mailing list