[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1536996:    (FORWARD_NULL)
/programs/pluto/routing.c: 987 in dispatch()


________________________________________________________________________________________________________
*** CID 1536996:    (FORWARD_NULL)
/programs/pluto/routing.c: 979 in dispatch()
973     		case X(DELETE_CHILD, ROUTED_TUNNEL, PERMANENT):
974     			/* permenant connections are never deleted */
975     			pexpect(keep_routed_tunnel_connection(c, where, e) == true);
976     			return;
977     		case X(TIMEOUT_CHILD, ROUTED_TUNNEL, INSTANCE):
978     		case X(DELETE_CHILD, ROUTED_TUNNEL, INSTANCE):
>>>     CID 1536996:    (FORWARD_NULL)
>>>     Passing "e" to "keep_routed_tunnel_connection", which dereferences null "e->child".
979     			if (keep_routed_tunnel_connection(c, where, e)) {
980     				return;
981     			}
982     			delete_connection(&c);
983     			return;
984     
/programs/pluto/routing.c: 987 in dispatch()
981     			}
982     			delete_connection(&c);
983     			return;
984     
985     		case X(TIMEOUT_CHILD, UNROUTED_NEGOTIATION, INSTANCE):
986     		case X(TIMEOUT_CHILD, UNROUTED, PERMANENT): /* permanent+up */
>>>     CID 1536996:    (FORWARD_NULL)
>>>     Dereferencing null pointer "e->child".
987     			if (should_revive_connection(*(e->child))) {
988     				schedule_revival(&(*e->child)->sa);
989     				delete_child_sa(e->child);
990     				return;
991     			}
992     			delete_child_sa(e->child);
/programs/pluto/routing.c: 975 in dispatch()
969     			delete_connection(&c);
970     			return;
971     
972     		case X(TIMEOUT_CHILD, ROUTED_TUNNEL, PERMANENT):
973     		case X(DELETE_CHILD, ROUTED_TUNNEL, PERMANENT):
974     			/* permenant connections are never deleted */
>>>     CID 1536996:    (FORWARD_NULL)
>>>     Passing "e" to "keep_routed_tunnel_connection", which dereferences null "e->child".
975     			pexpect(keep_routed_tunnel_connection(c, where, e) == true);
976     			return;
977     		case X(TIMEOUT_CHILD, ROUTED_TUNNEL, INSTANCE):
978     		case X(DELETE_CHILD, ROUTED_TUNNEL, INSTANCE):
979     			if (keep_routed_tunnel_connection(c, where, e)) {
980     				return;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYcO7W_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2BqaRf8mM-2BmDxmSf8RwbwtankecHghdBb8cd1O3RJ6vsTC6aGgSiQ1g6oNfVf4mtrSkmRqB99HJgpirj6S0Bt8-2FvcLSqORrMs-2FDsmLl6tv-2FvU-2F-2BtI3NUVXYIPTwy5rZqsnkSAUvfvUYnMYeaKymZUmrWU1NtiUmV5RO2VYtIeESUkH3LZZ0IZ8RI-2BBDiiatIXs-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxiRYu9_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2BqaRf8mM-2BmDxmSf8RwbwtankecHghdBb8cd1O3RJ6vsflX-2FC3Kq5p1AzIAr7dy-2F-2FyDhodRnVeGTp1YO9vsz1MvG8GVYK5QF8GD96xgNYarKukUjzlbl9aFEhNWKvttXnempwWOD4YpgXKLfe65Mow0nhpDnOothrapBMuuLQarvqzdCYvMGJ1l3D6NXcNkwlc-3D