[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

2 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1527500:    (DEADCODE)
/programs/pluto/kernel_xfrm.c: 2500 in xfrm_migrate_ipsec_sa_is_enabled()
/programs/pluto/kernel_xfrm.c: 2502 in xfrm_migrate_ipsec_sa_is_enabled()


________________________________________________________________________________________________________
*** CID 1527500:    (DEADCODE)
/programs/pluto/kernel_xfrm.c: 2500 in xfrm_migrate_ipsec_sa_is_enabled()
2494     	} state = UNKNOWN;
2495     	static const char disabled_message[] = "requires option CONFIG_XFRM_MIGRATE";
2496     	switch (state) {
2497     	case UNKNOWN:
2498     		state = qry_xfrm_mirgrate_support(logger) ? ENABLED : DISABLED;
2499     		return state == ENABLED ? NULL : disabled_message;
>>>     CID 1527500:    (DEADCODE)
>>>     Execution cannot reach this statement: "case ENABLED:".
2500     	case ENABLED:
2501     		return NULL;
2502     	case DISABLED:
2503     		return disabled_message;
2504     	default:
2505     		bad_case(state);
/programs/pluto/kernel_xfrm.c: 2502 in xfrm_migrate_ipsec_sa_is_enabled()
2496     	switch (state) {
2497     	case UNKNOWN:
2498     		state = qry_xfrm_mirgrate_support(logger) ? ENABLED : DISABLED;
2499     		return state == ENABLED ? NULL : disabled_message;
2500     	case ENABLED:
2501     		return NULL;
>>>     CID 1527500:    (DEADCODE)
>>>     Execution cannot reach this statement: "case DISABLED:".
2502     	case DISABLED:
2503     		return disabled_message;
2504     	default:
2505     		bad_case(state);
2506     	}
2507     }

** CID 1527499:  Memory - corruptions  (OVERRUN)
/programs/pluto/kernel_xfrm.c: 2445 in qry_xfrm_mirgrate_support()


________________________________________________________________________________________________________
*** CID 1527499:  Memory - corruptions  (OVERRUN)
/programs/pluto/kernel_xfrm.c: 2445 in qry_xfrm_mirgrate_support()
2439     		return false;
2440     	}
2441     
2442     	/* hdr->nlmsg_seq = ++seq; */
2443     	len = req.n.nlmsg_len;
2444     	do {
>>>     CID 1527499:  Memory - corruptions  (OVERRUN)
>>>     Overrunning struct type nlmsghdr of 16 bytes by passing it to a function which accesses it at byte offset 159 using argument "len" (which evaluates to 160).
2445     		r = write(nl_fd, &req.n, len);
2446     	} while (r < 0 && errno == EINTR);
2447     
2448     	if (r < 0) {
2449     		llog_error(logger, errno,
2450     			   "netlink write() xfrm_migrate_support lookup");


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYwQS0_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2FKbYG-2FTLXGT3o-2BL7mLZdDZuu6ilvJL08IXhJLody-2FHHR7waCgRWMHYSFeVgAJ9Ey-2B-2BkghjWVRL9Gj6qNRc031mSHL4kiA8vwi7PD9VGZMY6rbutAv7OpPz1lBXUwJZepBUHh1ywTXwHbsZAROGzbu99KHTAVvWO-2FUoYun1SREWsWeVvJobNUwC3xoijLi8xS4-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxiCzdS_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2FKbYG-2FTLXGT3o-2BL7mLZdDZuu6ilvJL08IXhJLody-2FHHaPzCEZdynncDr6I5cR3Vcd9tL87sU0t87yYqUOrLw6LaUlFfvLUcdaCbsS-2Fy8A5Sx4K-2BQeo-2Bd09OsEVXnq9ANN1iGZvY0twu7OkhTSlJH4jbuLPVYlfHDioL1-2Fey0wGQzgme9heWj2581DdU8NVQhI-3D