[Swan-dev] I think that Coverity found a bug in ECDSA_ipseckey_rdata_to_pubkey_content

Andrew Cagney andrew.cagney at gmail.com
Thu Dec 22 01:29:48 EET 2022


On Wed, 21 Dec 2022 at 03:14, D. Hugh Redelmeier <hugh at mimosa.com> wrote:
>
> The pointer variable "group" is initialized to NULL.
>
> group can then be set in the FOR_EACH_ELEMENT loop.
> Whenever it is set, the loop terminates.
> So the code in the loop that dereferences group must fail.
>
>         if (group->nss_adds_ec_point_form_uncompressed &&
>
> I guess that it has never been executed.

Yes.  We need to write an RFC.

> Since I don't (yet?) know what the code is supposed to do I don't know how
> to correct it.

Here (*e)-> would be correct.

>
> The test was added or changed in e3d98f1e2e6
> _______________________________________________
> Swan-dev mailing list
> Swan-dev at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-dev


More information about the Swan-dev mailing list