[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1529785:    (FORWARD_NULL)
/programs/pluto/kernel.c: 3230 in install_ipsec_spd_kernel_policies()
/programs/pluto/kernel.c: 3106 in install_ipsec_spd_kernel_policies()
/programs/pluto/kernel.c: 3091 in install_ipsec_spd_kernel_policies()
/programs/pluto/kernel.c: 3120 in install_ipsec_spd_kernel_policies()


________________________________________________________________________________________________________
*** CID 1529785:    (FORWARD_NULL)
/programs/pluto/kernel.c: 3230 in install_ipsec_spd_kernel_policies()
3224     
3225     		if (bspp != NULL) {
3226     			free_bare_shunt(bspp);
3227     		}
3228     
3229     		set_child_routing(c, RT_ROUTED_TUNNEL);
>>>     CID 1529785:    (FORWARD_NULL)
>>>     Dereferencing null pointer "st".
3230     		set_spd_owner(sr, st->st_serialno);
3231     		/* clear host shunts that clash with freshly installed route */
3232     		clear_narrow_holds(&sr->local->client, &sr->remote->client, logger);
3233     
3234     		return true;
3235     	} else {
/programs/pluto/kernel.c: 3106 in install_ipsec_spd_kernel_policies()
3100     						       &rsb));
3101     		}
3102     	}
3103     	if (spd->wip.conflicting.policy != esr) {
3104     		const struct spd_route *wspd = spd->wip.conflicting.route;
3105     		selector_pair_buf wsb, esb;
>>>     CID 1529785:    (FORWARD_NULL)
>>>     Dereferencing null pointer "st".
3106     		llog_pexpect(st->st_logger, HERE,
3107     			     "wip policy %s %s != %s %s",
3108     			     (wspd == NULL ? "<null>" : wspd->connection->name),
3109     			     str_selector_pair((wspd == NULL ? NULL : &wspd->local->client),
3110     					       (wspd == NULL ? NULL : &wspd->remote->client),
3111     					       &wsb),
/programs/pluto/kernel.c: 3091 in install_ipsec_spd_kernel_policies()
3085     			     str_selector_pair(&rosr->local->client,
3086     					       &rosr->remote->client,
3087     					       &rsb));
3088     		} else {
3089     			const struct spd_route *wspd = spd->wip.conflicting.route;
3090     			selector_pair_buf wsb, rsb;
>>>     CID 1529785:    (FORWARD_NULL)
>>>     Dereferencing null pointer "st".
3091     			llog_pexpect(st->st_logger, HERE,
3092     				     "wip route %s %s != %s %s",
3093     				     (wspd == NULL ? "<null>" : wspd->connection->name),
3094     				     str_selector_pair((wspd == NULL ? NULL : &wspd->local->client),
3095     						       (wspd == NULL ? NULL : &wspd->remote->client),
3096     						       &wsb),
/programs/pluto/kernel.c: 3120 in install_ipsec_spd_kernel_policies()
3114     					       (esr == NULL ? NULL : &esr->remote->client),
3115     					       &esb));
3116     	}
3117     	if (spd->wip.conflicting.shunt != bspp) {
3118     		struct bare_shunt **wbsp = spd->wip.conflicting.shunt;
3119     		selector_pair_buf wsb, bsp;
>>>     CID 1529785:    (FORWARD_NULL)
>>>     Dereferencing null pointer "st".
3120     		llog_pexpect(st->st_logger, HERE,
3121     			     "wip bsp %s != %s",
3122     			     str_selector_pair(wbsp == NULL ? NULL : &(*wbsp)->our_client,
3123     					       wbsp == NULL ? NULL : &(*wbsp)->peer_client,
3124     					       &wsb),
3125     			     str_selector_pair(bspp == NULL ? NULL : &(*bspp)->our_client,


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYzkQY_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ395raOjn0gp0sJh3wUkcN0rrz4AZR2NTU-2FT-2BSVf-2F-2F3KttuRQFgzAodyH9A3PJX2w6jGyjOenzUKkFruYxIDizUulnk4BSS60X-2B3pPiTukyDw-2BqCcJtpwnC4CgiE66dB7dr-2BeEI1c6VVtmz5-2FwWMZOIj3-2BI-2Bgh9BTKqYTojsKh667uU4KIgUzojssRXuuAErRvc-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxiAJtD_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ395raOjn0gp0sJh3wUkcN0rrz4AZR2NTU-2FT-2BSVf-2F-2F3KtnzMeL9Bn-2FiGngAkn3eAd1kAUr2Vlmeq6Qj5K1M9tYA7LmMIbgI-2BpEdS9-2FltDpZIXuzYH-2BtZTaTEdcYOQ4z1T6QaMnAhMIp61v4pcCrDQiyaa5ChnfByU5uzTT4lnaZyl9qE-2BOfoeKQY9A7GY-2F-2Bmr9M-3D