[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1529732:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/programs/pluto/connections.c: 3265 in instantiate()


________________________________________________________________________________________________________
*** CID 1529732:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/programs/pluto/connections.c: 3265 in instantiate()
3259     		 * template and not the hybrid.
3260     		 */
3261     		if (sec_label.len == 0) {
3262     			PASSERT(t->logger, t->kind == CK_TEMPLATE);
3263     			kind = CK_TEMPLATE; /*CK_HYBRID*/
3264     		} else {
>>>     CID 1529732:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
>>>     The expression "t->kind == CK_TEMPLATE || CK_HYBRID" is suspicious because it performs a Boolean operation on a constant other than 0 or 1.
3265     			PASSERT(t->logger, t->kind == CK_TEMPLATE || CK_HYBRID);
3266     			kind = CK_INSTANCE;
3267     		}
3268     	} else {
3269     		/* pexpect(address_is_specified(t->remote->host.addr) || peer_addr != NULL); true??? */
3270     		PASSERT(t->logger, t->kind == CK_TEMPLATE);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kY1cDD_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ392p3lB-2FuC8QbPMuTrk-2B6d4Y5NLPPsAAgAe-2BSwzSNPZS3RxcDiDkIX4FNhEb7EToDBqeByJ-2FBnO61-2Bgqa1xKK9KFeuzvpG4cNBB3varFXk-2BYDTgV5GHxryetDtS884cGGZMg2g4FTbnSbaMcfsRcBUJOKdfSH65yDhbfYLzq3vxFiK9zX7lEKVtUMkhJPZaayE-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudximkX7_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ392p3lB-2FuC8QbPMuTrk-2B6d4Y5NLPPsAAgAe-2BSwzSNPZS1obk1WSYZeCgAzWeLSqRVPw52WB0l3B0pY31eWobAQLSbPVm-2Fk4U4zmh-2BjCbXRoG0nJ5tPvodDdGxCGdQCiscv-2BGWZLy26OsANuZCm0zgOeIvvA0-2FOToNP-2FoL8dUxCjmFtSkowrkkrSKFk4mOepUPE-3D