[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1528010:  Error handling issues  (CHECKED_RETURN)
/programs/pluto/kernel.c: 1302 in migration_up()


________________________________________________________________________________________________________
*** CID 1528010:  Error handling issues  (CHECKED_RETURN)
/programs/pluto/kernel.c: 1302 in migration_up()
1296     	set_child_routing(c, RT_ROUTED_TUNNEL);
1297     	for (struct spd_route *sr = c->spd; sr != NULL; sr = sr->spd_next) {
1298     #ifdef IPSEC_CONNECTION_LIMIT
1299     		num_ipsec_eroute++;
1300     #endif
1301     		do_updown(UPDOWN_UP, c, sr, &child->sa, child->sa.st_logger);
>>>     CID 1528010:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "do_updown" without checking return value (as is done elsewhere 4 out of 5 times).
1302     		do_updown(UPDOWN_ROUTE, c, sr, &child->sa, child->sa.st_logger);
1303     	}
1304     }
1305     
1306     void migration_down(struct child_sa *child)
1307     {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYXEpL_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ39Mb0iEcZnX9FgC24HiUpLqNcEys7nfKfqGWkkpwDzy-2FzE-2Fhwc1A8-2FkMXZyDeLM1z6NNQfrQXtbqTDawmIGReKJ9zNq3BJ2bVMOvcMuTDgI2XwwZc-2FsvrZBf-2FZkmLEdlDLqQyqX5to8BClXpPgnw3Tg-2F5vYjpoWFWwEQfesqOn2fQrOU9Dj4m3sglTtmpiN-2BcM-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxiIqNF_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ39Mb0iEcZnX9FgC24HiUpLqNcEys7nfKfqGWkkpwDzy-2F-2BvJI7AI-2BKFFaBPy-2FBOlU9o7tQpXs2rQhC4jnpI6Z1FPTFMI-2BLdc-2Ft0vDDXvUlihbN-2F3OY27WuFnhOm5uxxmHnbxWyiXg2Zp-2Fsao6bksPrBT81P4y1903rv70OiyA5OW4b-2B3iCpu1oDKvRbT-2BloQLeI-3D