[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1507685:  Null pointer dereferences  (REVERSE_INULL)
/programs/pluto/ikev1_dpd.c: 74 in dpd_clear_connection()


________________________________________________________________________________________________________
*** CID 1507685:  Null pointer dereferences  (REVERSE_INULL)
/programs/pluto/ikev1_dpd.c: 74 in dpd_clear_connection()
68     	 * For CK_INSTANCE, delete_states_by_connection() will clear
69     	 * Note that delete_states_by_connection changes c->kind but we need
70     	 * to remember what it was to know if we still need to unroute after delete
71     	 */
72     	flush_pending_by_connection(c); /* remove any partial negotiations that are failing */
73     	delete_v1_states_by_connection_family(&c);
>>>     CID 1507685:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "c" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
74     	if (c != NULL) {
75     		dbg("%s: unrouting connection %s action - clearing",
76     		    enum_name(&connection_kind_names, c->kind), v);
77     		unroute_connection(c); /* --unroute */
78     	}
79     }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYHSJG_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2BrCR0i7YuOKwhGpQCBm9CgivcLye1giB7pvxOE-2BPr8gqHpbVnyJhQjct1PFATmwM5aSBYOB6V1V-2F6Tu-2FjIiRb9a9XXt2iaFm24El2wn83xf1ANtlAF5ZcnNbPiKC4xibTZAf9dxHXcXuAzWKpD6ir-2FkFkyvUMeBGg738Whg8YynFKd9AvhRkscGZOMX-2BqBjms-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxi0PZ3_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2BrCR0i7YuOKwhGpQCBm9CgivcLye1giB7pvxOE-2BPr8grMibaCGOuFwFAB4iviSz6tZhowzvG7vLPlhIwZhpmLyHJCgubexwXtU-2Fwtbf-2BoUM1w0zYs7z2F4s4K7LctHZYk7OzQKYfpCna-2Fx-2FWXjxDdRE6EFdE-2BtuiUIL1kD5n9QOTiPNYKNU44UDYIvKvS1tTY-3D