[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1505214:  Performance inefficiencies  (PASS_BY_VALUE)
/programs/pluto/ikev2_ts.c: 1033 in scribble_ts_on_connection()


________________________________________________________________________________________________________
*** CID 1505214:  Performance inefficiencies  (PASS_BY_VALUE)
/programs/pluto/ikev2_ts.c: 1033 in scribble_ts_on_connection()
1027     	}
1028     
1029     	return best_score;
1030     }
1031     
1032     static struct connection *scribble_ts_on_connection(struct connection *t, struct child_sa *child,
>>>     CID 1505214:  Performance inefficiencies  (PASS_BY_VALUE)
>>>     Passing parameter tsi of type "struct traffic_selectors const" (size 1032 bytes) by value.
1033     						    const struct traffic_selectors tsi,
1034     						    const struct traffic_selectors tsr,
1035     						    enum fit fit, bool definitely_shared)
1036     {
1037     	passert(tsi.nr >= 1);
1038     	int tsi_port = narrow_port(&t->spd.that, &tsi,


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYj7Po_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2BDkwXthCrkwuitIpbYwzrvNKhTab7N0uedSr-2B8hVVaET-2BXzvakZyOUE8BOuADI-2Fcwa5rWuLu5PwaWZefOZulgpRnOXiiv1NVaRpJXa8hM-2FXjXzWArPbQQo6bv5Fay-2Bdw-2BS3TKbhBKtqbCxIkjQnOTdJxTNE55tqY1tv0D1vRqL0-2FQgMNB526uCc-2F3PrLAkpSs-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxiJo4v_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2BDkwXthCrkwuitIpbYwzrvNKhTab7N0uedSr-2B8hVVaEdDW9E2lUAJpWnwKGdiosqMnumg01B1EnlWqxQwdFtZB5IZdrd8MQrLjiQYphdkEJ-2F5-2BmPqTKvyA8iG0mOzMRnQ5nFDEQ-2Bcof9jRBFYf1rguil1RABvQWYQ096Zj3RiBUlprYL2RAsLDkCbt0aoHArY-3D