[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1505724:  Control flow issues  (UNREACHABLE)
/testing/programs/ipcheck/ip_said_check.c: 99 in check_str_said()


________________________________________________________________________________________________________
*** CID 1505724:  Control flow issues  (UNREACHABLE)
/testing/programs/ipcheck/ip_said_check.c: 99 in check_str_said()
93     		/* convert it *to* internal format */
94     		ip_said sa;
95     		diag_t d = ttosaid(shunk1(t->in), &sa);
96     		if (d != NULL) {
97     			if (t->out != NULL) {
98     				FAIL("ttosaid(%s) unexpectedly failed: %s", t->in, str_diag(d));
>>>     CID 1505724:  Control flow issues  (UNREACHABLE)
>>>     This code cannot be reached: "pfree_diag(&d);".
99     				pfree_diag(&d);
100     			} else {
101     				/* all is good */
102     				pfree_diag(&d);
103     				continue;
104     			}


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYXpWd_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2BzNudNMNbn-2FM9D2SnrquHEdH6i4myMLtMuBF-2BjOg9T2iXFQewHSH3W8WzkvG8pP9RH7ygGcnIUiUWgU1pVsH3V-2BemkrZhrWWi6o81J-2BxypBlcX8nNahMuoajywbmzB-2FUA-2BTTcUw5fMrpk2AcXjHBoVBgpVMOfrAqHZrMKD8OARdd0iimNJiyfDYSseDyO2b50-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxigY3k_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2BzNudNMNbn-2FM9D2SnrquHEdH6i4myMLtMuBF-2BjOg9T2gE3Kc-2FcoufMdcudHEUbY6lHLF63-2FCppIyrMZ5VLPuLtxHZihjoodnVFmUtudOc3NFv1x3kaiwHgTEYKGlSLizgCgiU5Fwcd8QQG61x2hQin58M4Ub9BFYeXaQL0Iuh8vJNWna0nRv5xsPk-2F9jc-2BvYo-3D